Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Lib/idlelib/configdialog.py
Original file line number Diff line number Diff line change
Expand Up @@ -2265,7 +2265,11 @@ def make_callback(var, config):
"Return default callback function to add values to changes instance."
def default_callback(*params):
"Add config values to changes instance."
changes.add_option(*config, var.get())
value = var.get()
# A blanked int entry is an empty string; do not save it as an
# invalid config value (gh-83653).
if value != '':
changes.add_option(*config, value)
return default_callback

def attach(self):
Expand Down
11 changes: 11 additions & 0 deletions Lib/idlelib/idle_test/test_configdialog.py
Original file line number Diff line number Diff line change
Expand Up @@ -1544,6 +1544,17 @@ def test_make_callback(self):
self.assertEqual(changes['main']['section']['option'], '42')
changes.clear()

# gh-83653: a blank int entry is not saved as bad config data.
sv = StringVar(root)
cb = self.tracers.make_callback(sv, ('main', 'section', 'option'))
sv.set('')
cb()
self.assertNotIn('section', changes['main'])
sv.set('5')
cb()
self.assertEqual(changes['main']['section']['option'], '5')
changes.clear()

def test_attach_detach(self):
tr = self.tracers
iv = tr.add(self.iv, self.var_changed_increment)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Blanking an integer entry in IDLE's Settings dialog, such as "Auto squeeze
min lines", no longer saves an empty string as an invalid configuration
value.
Loading