gh-69134: Wait until mapped in SimpleDialog keyboard tests#152690
Conversation
serhiy-storchaka
force-pushed
the
gh-69134-map-simpledialog-tests
branch
from
9fb01c8 to
99cf022
Compare
The SimpleDialog keyboard tests generate key events after focus_force(), which on Windows are dropped until the toplevel is mapped, so they could fail intermittently (seen on the Windows10 buildbot as test_return_no_default). Wait until the window is mapped in each of these tests, as pythonGH-152599 did for the other keyboard tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
force-pushed
the
gh-69134-map-simpledialog-tests
branch
from
99cf022 to
1b5a7b2
Compare
serhiy-storchaka
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 1b5a7b2 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F152690%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-153104 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-153105 is a backport of this pull request to the 3.14 branch. |
|
GH-153106 is a backport of this pull request to the 3.13 branch. |
…-152690) (GH-153106) The SimpleDialog keyboard tests generate key events after focus_force(), which on Windows are dropped until the toplevel is mapped, so they could fail intermittently (seen on the Windows10 buildbot as test_return_no_default). Wait until the window is mapped in these tests, as GH-152599 did for the other keyboard tests. (cherry picked from commit 7d619c2) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
…-152690) (GH-153105) The SimpleDialog keyboard tests generate key events after focus_force(), which on Windows are dropped until the toplevel is mapped, so they could fail intermittently (seen on the Windows10 buildbot as test_return_no_default). Wait until the window is mapped in these tests, as GH-152599 did for the other keyboard tests. (cherry picked from commit 7d619c2) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
…-152690) (GH-153104) The SimpleDialog keyboard tests generate key events after focus_force(), which on Windows are dropped until the toplevel is mapped, so they could fail intermittently (seen on the Windows10 buildbot as test_return_no_default). Wait until the window is mapped in these tests, as GH-152599 did for the other keyboard tests. (cherry picked from commit 7d619c2) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2 participants
The
SimpleDialogtests generate key events afterfocus_force(). On Windows these are only delivered once the toplevel is mapped, so they could be dropped and the test fail intermittently — seen on the AMD64 Windows10 buildbot, wheretest_return_no_defaultfailed on the first run and passed on the re-run.Unlike the query dialogs (whose
__init__callswait_visibility()),SimpleDialogonly waits for its window ingo(), which these tests bypass. Wait until the window is mapped in thecreate()helper, as GH-152599 did for the other keyboard tests.