gh-152586: Make tempfile.TemporaryFileWrapper public#152646
Open
Aniketsy wants to merge 2 commits into
Open
Conversation
Documentation build overview
15 files changed ·
|
sobolevn
reviewed
Jul 1, 2026
| self.assertIn("TemporaryFileWrapper", tempfile.__all__) | ||
|
|
||
| def test_is_return_type_of_named_temporary_file(self): | ||
| with tempfile.NamedTemporaryFile() as f: |
Member
There was a problem hiding this comment.
I propose to move this check to any existing test above.
| for line in self.file: | ||
| yield line | ||
|
|
||
| _TemporaryFileWrapper = TemporaryFileWrapper |
Member
There was a problem hiding this comment.
Please, add a comment: why it is there.
Question: does it make sence to deprecate the older alias at the same time?
Contributor
Author
There was a problem hiding this comment.
Please, add a comment: why it is there.
sure 👍
Question: does it make sence to deprecate the older alias at the same time?
I think we can deprecate in follow up, but if you prefer we should add in this PR, only-- i'm happy to go with
Thanks for the review!
Member
There was a problem hiding this comment.
I would deprecate it right away :)
Co-authored-by: sobolevn <mail@sobolevn.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152586