gh-152600: Remove LOAD_FAST/LOAD_FAST_BORROW; POP_TOP pairs#152643
Open
brijkapadia wants to merge 3 commits into
Open
gh-152600: Remove LOAD_FAST/LOAD_FAST_BORROW; POP_TOP pairs#152643brijkapadia wants to merge 3 commits into
LOAD_FAST/LOAD_FAST_BORROW; POP_TOP pairs#152643brijkapadia wants to merge 3 commits into
Conversation
Changes - moved `add_checks_for_loads_of_uninitialized_variables` earlier so that a `LOAD_FAST` that should be a `LOAD_FAST_CHECK` are not removed. - refactored `remove_redundant_nops_and_pairs` to be more concise. Also extended it so that any `COPY` gets removed. I don't think there is any reason to only remove `COPY` with an `oparg` of 1. I don't think a NEWS entry is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
add_checks_for_loads_of_uninitialized_variablesearlier so that aLOAD_FASTthat should be aLOAD_FAST_CHECKis not removed.remove_redundant_nops_and_pairsto be more concise. Also extended it so that anyCOPYgets removed. I don't think there is any reason to only removeCOPYwith anopargof 1.I don't think a NEWS entry is needed.
LOAD_FAST_BORROW; POP_TOPpairs should be removed #152600