gh-152248: Fix zoneinfo TZ string regex to only accept ASCII letters#152510
Closed
factnn wants to merge 1 commit into
Closed
gh-152248: Fix zoneinfo TZ string regex to only accept ASCII letters#152510factnn wants to merge 1 commit into
factnn wants to merge 1 commit into
Conversation
…tters The pure-Python _parse_tz_str regex used [^<0-9:.+-]+ for unquoted abbreviations, which matched whitespace and non-ASCII characters. The C implementation only accepts ASCII letters. Tighten the regex to [a-zA-Z]+ to match C behavior.
Member
|
This already has an open PR, closing in favour of it: #152249 |
Author
|
didn't notice #152249 — closing as duplicate, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152248
The pure-Python
_parse_tz_strregex used[^<0-9:.+-]+forunquoted abbreviations, which matched whitespace and non-ASCII
characters. The C implementation only accepts ASCII letters.
Tighten the regex to
[a-zA-Z]+to match C behavior.