gh-152502: Detect optional curses functions with configure probes#152504
Merged
serhiy-storchaka merged 3 commits intoJun 29, 2026
Conversation
Some curses functions were called unconditionally or gated only by the ncurses-specific NCURSES_EXT_FUNCS macro, which broke building the module against other curses implementations (narrow ncurses, NetBSD curses) even when they provided the function. Detect each with a configure capability probe and gate on HAVE_CURSES_*. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
# Conflicts: # Modules/clinic/_cursesmodule.c.h
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-152589 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jun 29, 2026
…re probes (pythonGH-152504) set_escdelay(), set_tabsize() and the ESCDELAY and TABSIZE variables were gated only by the ncurses-specific NCURSES_EXT_FUNCS macro, which excluded them when building against other curses implementations such as NetBSD curses even when they provided them. Detect each with a configure capability probe and gate on HAVE_CURSES_*. (cherry picked from commit 0635e55) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
removed
needs backport to 3.13
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 29, 2026
…bes (GH-152504) (GH-152589) set_escdelay(), set_tabsize() and the ESCDELAY and TABSIZE variables were gated only by the ncurses-specific NCURSES_EXT_FUNCS macro, which excluded them when building against other curses implementations such as NetBSD curses even when they provided them. Detect each with a configure capability probe and gate on HAVE_CURSES_*. (cherry picked from commit 0635e55) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 29, 2026
…bes (GH-152504) (GH-152589) (GH-152603) set_escdelay(), set_tabsize() and the ESCDELAY and TABSIZE variables were gated only by the ncurses-specific NCURSES_EXT_FUNCS macro, which excluded them when building against other curses implementations such as NetBSD curses even when they provided them. Detect each with a configure capability probe and gate on HAVE_CURSES_*. (cherry picked from commit 0635e55) (cherry picked from commit 2a4ffa6) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 29, 2026
…bes (GH-152504) (GH-152589) (GH-152602) set_escdelay(), set_tabsize() and the ESCDELAY and TABSIZE variables were gated only by the ncurses-specific NCURSES_EXT_FUNCS macro, which excluded them when building against other curses implementations such as NetBSD curses even when they provided them. Detect each with a configure capability probe and gate on HAVE_CURSES_*. (cherry picked from commit 0635e55) (cherry picked from commit 2a4ffa6) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some functions in
Modules/_cursesmodule.cwere called unconditionally or gated only by the ncurses-specificNCURSES_EXT_FUNCSmacro, which broke building the module against curses implementations other than ncursesw (narrow ncurses, NetBSD curses) even when the library provided the function. Detect each with aconfigurecapability probe and gate onHAVE_CURSES_*:PY_CHECK_CURSES_FUNCprobes forscr_dump(one probe gates the inseparablescr_dump/scr_restore/scr_init/scr_setfamily),key_defined,term_attrs,define_key,keyok,set_escdelay,set_tabsize;PY_CHECK_CURSES_VARmacro forget_escdelay/get_tabsize, which read theESCDELAY/TABSIZEvariables rather than functions;test_env_queriesnow guardsterm_attrs()withhasattr().None of these are in X/Open Curses; they are ncurses extensions (NetBSD provides compatible ones), so a capability probe is more portable than conditioning on
NCURSES_VERSION.No behaviour change on standard ncursesw.
test_cursespasses and is refleak-clean on wide ncursesw, narrow ncurses, and NetBSD curses, under UTF-8 and 8-bit locales.Note:
configurewas edited by hand; please runmake regen-configureto confirm it matches the pinned autoconf toolchain.🤖 Generated with Claude Code