Skip to content

gh-152375: Fix UB in INSTRUMENTED_JUMP#152376

Merged
StanFromIreland merged 2 commits into
python:mainfrom
StanFromIreland:INSTRUMENTED_JUMP-ub
Jun 29, 2026
Merged

gh-152375: Fix UB in INSTRUMENTED_JUMP#152376
StanFromIreland merged 2 commits into
python:mainfrom
StanFromIreland:INSTRUMENTED_JUMP-ub

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Jun 27, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

I didn't add a test, I think it's too messy here, but I don't feel strongly about it. It is also already covered (non-deterministically) by test_monitoring, as that's what triggered UBSan.

@bedevere-app bedevere-app Bot mentioned this pull request Jun 27, 2026
Closed
@StanFromIreland

This comment was marked as off-topic.

Sign in to view
This was referenced Jun 27, 2026
Closed
Open
@serhiy-storchaka

This comment was marked as off-topic.

Sign in to view
iritkatriel
iritkatriel reviewed Jun 27, 2026
View reviewed changes
Comment thread Python/ceval_macros.h
@StanFromIreland StanFromIreland added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 27, 2026
@StanFromIreland StanFromIreland merged commit cdec9ac into python:main Jun 29, 2026
69 checks passed
@StanFromIreland StanFromIreland deleted the INSTRUMENTED_JUMP-ub branch June 29, 2026 09:06
@miss-islington-app

miss-islington-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

GH-152566 is a backport of this pull request to the 3.15 branch.

@miss-islington-app

miss-islington-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cdec9acd63c33d9b822700de8f63eb94d86e1c93 3.13

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 29, 2026
@bedevere-app

bedevere-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

GH-152567 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 29, 2026
@StanFromIreland

StanFromIreland commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review!

StanFromIreland added a commit that referenced this pull request Jun 29, 2026
@miss-islington @StanFromIreland
[3.14] gh-152375: Fix undefined behaviour in the INSTRUMENTED_JUMP …
be68d9a 
…macro (GH-152376) (#152567)

(cherry picked from commit cdec9ac)

Co-authored-by: Stan Ulbrych <stan@python.org>
@bedevere-app

bedevere-app Bot commented Jun 29, 2026

Copy link
Copy Markdown

GH-152577 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 29, 2026
StanFromIreland added a commit that referenced this pull request Jun 29, 2026
@miss-islington @StanFromIreland
[3.15] gh-152375: Fix undefined behaviour in the INSTRUMENTED_JUMP …
00a4304 
…macro (GH-152376) (#152566)

(cherry picked from commit cdec9ac)

Co-authored-by: Stan Ulbrych <stan@python.org>
StanFromIreland added a commit that referenced this pull request Jun 29, 2026
@StanFromIreland
[3.13] gh-152375: Fix undefined behaviour in the INSTRUMENTED_JUMP …
1638151 
…macro (GH-152376) (#152577)

(cherry picked from commit cdec9ac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@StanFromIreland StanFromIreland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @serhiy-storchaka @iritkatriel