gh-81954: Warn when ZipFile is closed with unwritten data#152354
Open
cmaloney wants to merge 2 commits into
Open
gh-81954: Warn when ZipFile is closed with unwritten data#152354cmaloney wants to merge 2 commits into
cmaloney wants to merge 2 commits into
Conversation
Bring `zipfile.ZipFile` into alignment with other buffered file writers like `GzipFile` and `TextIOWrapper` by emitting a `ResourceWarning` if there is unwritten data and it is closed implicitly. ZipFile should be closed either by using it as a context manager or explicitly calling `.close()`.
Documentation build overview
54 files changed ·
|
emmatyping
reviewed
Jul 5, 2026
| self.fixtures.enter_context(warnings.catch_warnings()) | ||
| warnings.filterwarnings( | ||
| 'ignore', category=ResourceWarning, message='unclosed ZipFile' | ||
| ) |
Member
There was a problem hiding this comment.
Perhaps it would be better to have the fixtures yield the zipfile and close it after so they don't leak the resource?
Contributor
Author
There was a problem hiding this comment.
Tried yielding but it added a lot of code. Moved so that the fixture binding code will auto-enter context manager objects + using unittest.enterContext
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring
zipfile.ZipFileinto alignment with other buffered file writers likeGzipFileandTextIOWrapperby emitting aResourceWarningif there is unwritten data and it is closed implicitly.ZipFile should be closed either by using it as a context manager or explicitly calling
.close().cc: @jaraco the
_path/test_pathfixtures have quite a few ZipFiles they don't close. For now I just blanket silenced, not sure your preferred upstream fix.