gh-121249: Deprecate using F/D type codes in the struct module#152309
Open
skirpichev wants to merge 6 commits into
Open
gh-121249: Deprecate using F/D type codes in the struct module#152309skirpichev wants to merge 6 commits into
skirpichev wants to merge 6 commits into
Conversation
Documentation build overview
29 files changed ·
|
vstinner
reviewed
Jun 29, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
IMO F/D formats soft deprecation should be removed from Doc/deprecations/soft-deprecations.rst, since the formats are now hard deprecated.
| with self.subTest(format=f): | ||
| with warnings.catch_warnings(): | ||
| warnings.simplefilter("error", DeprecationWarning) | ||
| self.assertRaises(DeprecationWarning, struct.pack, f, z) |
Member
There was a problem hiding this comment.
We already check with self.assertWarns(DeprecationWarning): below. I'm not sure that checking for DeprecationWarning exception is useful.
Member
Author
There was a problem hiding this comment.
We do this in other places.
Co-authored-by: Victor Stinner <vstinner@python.org>
Member
Author
Sure, I completely forgot that file. Done, with other requested changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.