gh-86165: Fix Time2Internaldate with datetime timetuple#151844
Merged
Conversation
serhiy-storchaka
approved these changes
Jul 2, 2026
Comment on lines
+1847
to
+1850
| try: | ||
| gmtoff = date_time.tm_gmtoff | ||
| except AttributeError: | ||
| gmtoff = None |
Member
There was a problem hiding this comment.
This can also be written as
gmtoff = getattr(date_time, 'tm_gmtoff', None)But it is up to you.
Contributor
Author
There was a problem hiding this comment.
Agreed, this is more compact. Updated, thanks for the review.
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @yuanx749 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-152895 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-152896 is a backport of this pull request to the 3.14 branch. |
|
GH-152897 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jul 2, 2026
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jul 2, 2026
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-86165.
The issue explains the cause clearly:
datetime.datetime.timetuple()returns atime.struct_timewithtm_gmtoffpresent but set toNone, so theAttributeErrorfallback is skipped.This change falls back to the local timezone offset when
tm_gmtoffisNone.