Skip to content

GH-151672: __lazy_import__ always resolves to the module being imported#151827

Merged
pablogsal merged 2 commits into
python:mainfrom
brandtbucher:codex/fix-lazy-import-fromlist
Jun 28, 2026
Merged

GH-151672: __lazy_import__ always resolves to the module being imported#151827
pablogsal merged 2 commits into
python:mainfrom
brandtbucher:codex/fix-lazy-import-fromlist

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Jun 21, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Fix an inconsistency where calling __lazy_import__ with a string fromlist would resolve to the named member, rather than the module being imported (which is what other fromlist types and __import__ all do).

@bedevere-app bedevere-app Bot mentioned this pull request Jun 21, 2026
Open
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-lazy-imports needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 21, 2026
@brettcannon brettcannon removed their request for review June 22, 2026 19:28
pablogsal
pablogsal approved these changes Jun 28, 2026
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pablogsal pablogsal merged commit 2d0003c into python:main Jun 28, 2026
68 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 28, 2026

Copy link
Copy Markdown

Thanks @brandtbucher for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 28, 2026

Copy link
Copy Markdown

GH-152534 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 28, 2026
pablogsal pushed a commit that referenced this pull request Jun 29, 2026
@miss-islington @brandtbucher
[3.15] GH-151672: __lazy_import__ always resolves to the module bei…
2b92f57 
…ng imported (GH-151827) (#152534)

GH-151672: `__lazy_import__` always resolves to the module being imported (GH-151827)
(cherry picked from commit 2d0003c)

Co-authored-by: Brandt Bucher <brandt@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@Yhg1s Yhg1s Awaiting requested review from Yhg1s Yhg1s is a code owner
@DinoV DinoV Awaiting requested review from DinoV DinoV is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-lazy-imports type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brandtbucher @pablogsal