gh-151669: Normalize symlink targets in tarfile.TarFile.gettarinfo()#151671
gh-151669: Normalize symlink targets in tarfile.TarFile.gettarinfo()#151671dnicolodi wants to merge 2 commits into
Conversation
…nfo() This applies a normalization complementary to the one added to tarfile.TarFile.extract() in pythongh-138309.
|
All commit authors signed the Contributor License Agreement. |
|
I think this change should be mentioned in NEWS next to the one to |
|
According to the CI message, the news entry should be added to |
I understand this, but in this case I think the best would be to extend the NEWS entry added by gh-138309, and I don't know what is the policy for doing this. |
|
@hugovk can you help clarify how the news entry should be handled here? Should @dnicolodi simply add a new one? |
|
The changelog is a never-ending history of archeological layers. The NEWS entry added by #138309 is what happened in 3.15.0a1. That's the past. The NEWS entry for this PR is what will happen in 3.15.0b4. Please add a new NEWS entry for this change. General info: https://devguide.python.org/getting-started/pull-request-lifecycle/#updating-news-and-what-s-new-in-python |
Documentation build overview
|
dnicolodi
force-pushed
the
fix/win-tarfile-gettarinfo
branch
from
630da42 to
52b2be0
Compare
|
@hugovk gave his approval for merging this #138309 (comment) Is there anything I can help with to have this merged? @encukou |
|
Also just in case it isn't clear, fixing this is needed for meson-python to correctly create sdists on Windows using Python 3.15. |
|
Do you want to add a test as well? If not I'll add one later this week. |
5 participants
This applies a normalization complementary to the one added to tarfile.TarFile.extract() in gh-138309.
tarfile.TarFile.add()does not normalize symlink targets on Windows #151669