gh-150506: Improve inspect.getattr_static example code#150507
Open
jonathandung wants to merge 2 commits into
Open
gh-150506: Improve inspect.getattr_static example code#150507jonathandung wants to merge 2 commits into
inspect.getattr_static example code#150507jonathandung wants to merge 2 commits into
Conversation
jonathandung
changed the title
inspect.getattr_static example code in [documentation page](https://docs.python.org/3/library/inspect.html#inspect.getattr_static) work correctlyinspect.getattr_static example code in documentation page work correctly
Contributor
Author
|
See the page |
Documentation build overview
183 files changed ·
|
picnixz
changed the title
inspect.getattr_static example code in documentation page work correctlyinspect.getattr_static example code
picnixz
reviewed
Jul 5, 2026
| wrapper_descriptor = type(str.__dict__['__add__']) | ||
| descriptor_types = (slot_descriptor, getset_descriptor, wrapper_descriptor) | ||
| import types | ||
| descriptor_types = (types.MemberDescriptorType, types.GetSetDescriptorType, types.WrapperDescriptorType) |
Member
There was a problem hiding this comment.
Put it in the isinstance check instead.
Contributor
Author
There was a problem hiding this comment.
Done.
I remember there are also method_descriptor and classmethod_descriptor. Are they relevant here?
Originally posted by @jonathandung in #150504 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inspect.getattr_staticusage snippet to resolve built-in C descriptors and hackiness in how it obtains these types #150506