gh-149689: add missing error checks in Parser/action_helpers.c#149710
Merged
pablogsal merged 2 commits intoJun 29, 2026
Conversation
Documentation build overview
154 files changed ·
|
eendebakpt
reviewed
May 12, 2026
| @@ -1416,6 +1432,9 @@ expr_ty | |||
| _PyPegen_template_str(Parser *p, Token *a, asdl_expr_seq *raw_expressions, Token *b) { | |||
|
|
|||
| asdl_expr_seq *resized_exprs = _get_resized_exprs(p, a, raw_expressions, b, TSTRING); | |||
| if (!resized_exprs && PyErr_Occurred()) { | |||
Contributor
There was a problem hiding this comment.
The && PyErr_Occurred() is redundant here, but is not hurting either.
pablogsal
force-pushed
the
kowalski/fix-add-missing-error-checks
branch
from
2285902 to
9c719d8
Compare
pablogsal
added
needs backport to 3.13
|
Thanks @KowalskiThomas for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-152640 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
Sorry, @KowalskiThomas and @pablogsal, I could not cleanly backport this to |
|
GH-152641 is a backport of this pull request to the 3.14 branch. |
pablogsal
pushed a commit
that referenced
this pull request
Jun 30, 2026
pablogsal
pushed a commit
that referenced
this pull request
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149689.
Parser/action_helpers.c#149689