gh-146219: Document reusing a thread state across repeated foreign-thread calls#146221
Merged
gpshead merged 3 commits intoJun 30, 2026
Merged
Conversation
Member
|
This PR is stale because it has been open for 30 days with no activity. |
Member
|
PEP 788 API has been merged in Python 3.15: https://docs.python.org/dev/c-api/interp-lifecycle.html#cautions-regarding-runtime-finalization. The PR may need to be updated to refer to these APIs. |
Add a subsection under "Non-Python created threads" explaining the performance cost of creating/destroying a PyThreadState on every Ensure/Release cycle and showing how to keep one alive for the thread's lifetime instead.
…-reentrant-performance
9d7365d to
7fe5619
Compare
Member
Author
|
updated, please take another look. |
Documentation build overview
8 files changed ·
|
ZeroIntensity
approved these changes
Jun 29, 2026
ZeroIntensity
left a comment
Member
There was a problem hiding this comment.
LGTM, with one minor typo.
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-152644 is a backport of this pull request to the 3.15 branch. |
gpshead
added a commit
that referenced
this pull request
Jun 30, 2026
…eign-thread calls (GH-146221) (#152644) gh-146219: Document reusing a thread state across repeated foreign-thread calls (GH-146221) * Document reusing a thread state across repeated foreign-thread calls Add a subsection under "Non-Python created threads" explaining the performance cost of creating/destroying a PyThreadState on every Ensure/Release cycle and showing how to keep one alive for the thread's lifetime instead. * add a comma --------- (cherry picked from commit 5717518) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a subsection under "Non-Python created threads" explaining the performance cost of creating/destroying a PyThreadState on every Ensure/Release cycle and showing how to keep one alive for the thread's lifetime instead.
(read them & see the issue for more details)
📚 Documentation preview 📚: https://cpython-previews--146221.org.readthedocs.build/