Skip to content

Remove PDF images#145977

Merged
hugovk merged 4 commits into
python:mainfrom
StanFromIreland:remove-pdf
Jul 5, 2026
Merged

Remove PDF images#145977
hugovk merged 4 commits into
python:mainfrom
StanFromIreland:remove-pdf

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Mar 15, 2026

Copy link
Copy Markdown
Member

With #145480, these will be automatically converted if necessary.


📚 Documentation preview 📚: https://cpython-previews--145977.org.readthedocs.build/

@StanFromIreland

Copy link
Copy Markdown
Member Author

CC @m-aciek

@StanFromIreland

StanFromIreland commented Mar 15, 2026

Copy link
Copy Markdown
Member Author

EPUB is failing, but it has always used the SVG? I'll try figure it out.

Edit: It seems .. only:: html is in fact, not only HTML.

@StanFromIreland StanFromIreland requested a review from hugovk March 15, 2026 16:16

@m-aciek m-aciek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread Doc/c-api/lifecycle.rst Outdated
Comment thread Doc/c-api/lifecycle.rst Outdated
@github-actions

This comment was marked as spam.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 17, 2026
StanFromIreland and others added 2 commits June 22, 2026 21:06
@StanFromIreland StanFromIreland requested a review from m-aciek June 22, 2026 20:07
@StanFromIreland

Copy link
Copy Markdown
Member Author

Good catch, thanks @m-aciek!

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jun 23, 2026
@m-aciek

m-aciek commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

For the record, triggered builds of offline docs formats (including PDF) to make sure it passes: https://github.com/m-aciek/python-docs-offline/actions/runs/28710825478

@m-aciek m-aciek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, builds passed successfully. I cannot approve at GH PR level.

Only users with explicit access to this repository may approve pull requests

@hugovk

hugovk commented Jul 5, 2026

Copy link
Copy Markdown
Member

This looks good to me, builds passed successfully.

Thanks for testing!

I cannot approve at GH PR level.

Only users with explicit access to this repository may approve pull requests

Yeah, we turned that off after getting spam reviews. Your approval comment is appreciated!

@hugovk hugovk merged commit 5616505 into python:main Jul 5, 2026
51 of 53 checks passed
@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 5, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @StanFromIreland and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5616505b443b13d9f5766dedcf6c0b43167705b6 3.13

@bedevere-app

bedevere-app Bot commented Jul 5, 2026

Copy link
Copy Markdown

GH-153064 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 5, 2026
@bedevere-app

bedevere-app Bot commented Jul 5, 2026

Copy link
Copy Markdown

GH-153065 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 5, 2026
@m-aciek

m-aciek commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

This shouldn't be backported to 3.13, as we support SVG conversion for 3.14+. #139588

Hm, I think I may be wrong, lifecycle graphics probably were added for 3.14. And turtle star were superfluous earlier -- there's the PNG format.

@StanFromIreland StanFromIreland deleted the remove-pdf branch July 5, 2026 08:15
@StanFromIreland

Copy link
Copy Markdown
Member Author

Since there are also conflicts, I think we can skip the backport.

@StanFromIreland StanFromIreland removed the needs backport to 3.13 bugs and security fixes label Jul 5, 2026
StanFromIreland added a commit that referenced this pull request Jul 5, 2026
(cherry picked from commit 5616505)

Co-authored-by: Stan Ulbrych <stan@python.org>
Co-authored-by: Maciej Olko <maciej.olko@affirm.com>
StanFromIreland added a commit that referenced this pull request Jul 5, 2026
(cherry picked from commit 5616505)

Co-authored-by: Stan Ulbrych <stan@python.org>
Co-authored-by: Maciej Olko <maciej.olko@affirm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants