Use a (smart) set of branches for branch selection#752
Open
encukou wants to merge 2 commits into
Open
Conversation
zware
approved these changes
Jul 2, 2026
Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
branchesattribute on worker, builderdef & buildfactory objects. This is a set(-like) of branches the object applies to.The set of all branches is exposed as
branches.BRANCHES, in a custom object with some convenience APIs.This replaced several ways of filtering which branches apply to a given build:
builders.ONLY_MAIN_BRANCH-- a set of name fragments; builds with matching names are limited to the main & PR branchbranches¬_brancheslists: these were usually for testing a feature introduced in 3.X, or made obsolete in 3.X. I tried several variants before settling ononly_since&only_until.wasm_tier& thewasmtag. This PR happened to bring the WASM skipping logic to one place, with comments talking about specific versions. So I removed thewasm_tierattribute on BranchInfo objects.Let me know if this seems like a good direction.
I made the
generate_builderdefsfunction from #736 takeBuilderDefobjects in addition to tuples. Avoiding unrelated moves makes for simpler diffs.I'm filing PRs with individual changes from @zware's branch, to review/test/fixup/revert the changes one by one. This is based -- very loosely this time -- on 82eb39d.