Skip to content

feat(resolver): add LegacyResolver for legacy resolution and download#1237

Draft
tiran wants to merge 1 commit into
python-wheel-build:mainfrom
tiran:legacy-resolver
Draft

feat(resolver): add LegacyResolver for legacy resolution and download#1237
tiran wants to merge 1 commit into
python-wheel-build:mainfrom
tiran:legacy-resolver

Conversation

@tiran

@tiran tiran commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Description

What

Add LegacyResolver class that preserves the existing resolution and
download behavior as a typed resolver. When the source field is
eventually enabled on PackageSettings, packages without an explicit
typed resolver can use provider: legacy to keep the old behavior.

resolver_provider() replicates sources.get_source_provider(): reads
resolver_dist settings from per-package build info, invokes the
get_resolver_provider override hook, and applies the per-package
cooldown.

download() checks pbi.pre_built: when true, delegates to the
pre-built wheel downloader; otherwise invokes the download_source
override hook via overrides.find_and_invoke().

Why

Legacy provider will be used to gradually update to new resolver and downloader.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c35fdb52-33a7-4901-80a2-cfbc5161169c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the ci label Jul 7, 2026
@mergify

mergify Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.
@tiran please rebase your branch.

Add `LegacyResolver` class that preserves the existing resolution and
download behavior as a typed resolver. When the `source` field is
eventually enabled on `PackageSettings`, packages without an explicit
typed resolver can use `provider: legacy` to keep the old behavior.

`resolver_provider()` replicates `sources.get_source_provider()`: reads
`resolver_dist` settings from per-package build info, invokes the
`get_resolver_provider` override hook, and applies the per-package
cooldown.

`download()` checks `pbi.pre_built`: when true, delegates to the
pre-built wheel downloader; otherwise invokes the `download_source`
override hook via `overrides.find_and_invoke()`.

Co-Authored-By: Claude <claude@anthropic.com>
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran force-pushed the legacy-resolver branch from fe6b896 to 6f734b6 Compare July 7, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant