Allow dotted test filenames (*.test.py) via dot-escape in compute_module_name#14750
Open
Abhi-DevHub wants to merge 4 commits into
Open
Allow dotted test filenames (*.test.py) via dot-escape in compute_module_name#14750Abhi-DevHub wants to merge 4 commits into
Abhi-DevHub wants to merge 4 commits into
Conversation
Abhi-DevHub
force-pushed
the
fix/dotted-test-filename
branch
from
July 21, 2026 18:05
db6e9f0 to
ce1d906
Compare
psf-chronographer
Bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escape dots inside path parts in
compute_module_name, the same waymodule_name_from_pathalready does. This mapspkg/foo.test.pyto modulepkg.foo_testinstead of the invalidpkg.foo.test.The change is one line — the same
p.replace(., _)pattern already used by the siblingmodule_name_from_pathfallback.closes: #14514