fix: propagate package-level pytestmark from __init__.py#14740
Closed
Solaris-star wants to merge 2 commits into
Closed
fix: propagate package-level pytestmark from __init__.py#14740Solaris-star wants to merge 2 commits into
Solaris-star wants to merge 2 commits into
Conversation
After Package stopped being a Module/File, pytestmark defined in a package __init__.py was no longer applied to contained tests, so package-level skip/xfail markers were ignored. Load __init__.py during Package.collect and extend own_markers/keywords from get_unpacked_marks, matching Module/PyCollector behaviour. Fixes pytest-dev#14737
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A package-level marker in
__init__.pyused to apply to tests under that package. AfterPackagestopped being aModule/File, those markers were never loaded intoown_markers, so tests ran instead of being skipped/xfailed.Fix
In
Package.collect(), import__init__.pyviaimporttestmoduleand applyget_unpacked_marks(init_mod)to the package node'sown_markers/keywords. Children inherit markers through parent walk initer_markers_with_node.Test
Linked Issue
Closes #14737