fix #6881 - add policies for too long ids from a str and use short as default#13370
Merged
RonnyPfannschmidt merged 1 commit intoJul 21, 2026
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/_pytest/python.py:114
- Typo 'parameer' should be 'parameter', and the help text mentions 'sha3' while the code uses hashlib.sha256. Please update for consistency.
help="strategy for parameer values that result in long ids\n- short: default: shorten the value normally\n- hash: take a sha3 of the value for content matching ids\n- legacy: keep the long id (only use this for temporary backward compatibility)\n- disallow: fail and request explicit ids",
testing/python/metafunc.py:666
- [nitpick] The expected output for the 'short' strategy ('a0') when the input string is long is non-obvious. Please add a comment to clarify the rationale for this expected value.
"short": "a0",
RonnyPfannschmidt
force-pushed
the
fix-6881-long-str-shal-not-be-a-id
branch
from
May 26, 2026 06:38
0002440 to
23ad79b
Compare
RonnyPfannschmidt
force-pushed
the
fix-6881-long-str-shal-not-be-a-id
branch
from
May 26, 2026 06:43
23ad79b to
53e0044
Compare
psf-chronographer
Bot
added
the
bot:chronographer:provided
RonnyPfannschmidt
force-pushed
the
fix-6881-long-str-shal-not-be-a-id
branch
2 times, most recently
from
May 26, 2026 21:00
72b00d3 to
a299e77
Compare
RonnyPfannschmidt
force-pushed
the
fix-6881-long-str-shal-not-be-a-id
branch
3 times, most recently
from
May 27, 2026 06:14
7709729 to
4238d9c
Compare
RonnyPfannschmidt
marked this pull request as ready for review
May 27, 2026 06:14
Add a configurable strategy for handling long str/bytes parameter values in auto-generated test IDs. Strategies: - short (default): values over 100 chars fall back to argname+index - sha256: replace with SHA-256 hex digest - legacy: keep the full value as-is - disallow: raise an error requesting explicit IDs Only affects auto-generated IDs — explicit ids=[...] and pytest.param(id=...) are unchanged. Unknown strategy values raise UsageError. Includes confval docs entry and changelog. Closes pytest-dev#6881 Co-authored-by: Cursor AI <ai@cursor.sh> Co-authored-by: Claude Opus 4 <claude-opus-4@anthropic.com>
RonnyPfannschmidt
force-pushed
the
fix-6881-long-str-shal-not-be-a-id
branch
from
July 21, 2026 08:55
4238d9c to
33ebdb1
Compare
Zac-HD
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this experiments with addign a policy and a new default
closes #6881