feat: add octicons-react-symbols package by joshblack · Pull Request #8029 · primer/react

joshblack · 2026-06-22T20:29:54Z

Closes #

Changelog

New

Changed

Removed

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github-ui (Learn more about how to run integration tests)

…-react-symbols-exploration

changeset-bot · 2026-06-22T20:30:00Z

🦋 Changeset detected

Latest commit: 9c5c2ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/octicons-react-symbols	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-06-22T20:30:26Z

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. If this doesn't work, you can also use the original workflow here. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

primer · 2026-06-22T20:36:59Z

🤖 Lint issues have been automatically fixed and committed to this PR.

primer · 2026-06-22T20:43:43Z

🤖 Lint issues have been automatically fixed and committed to this PR.

primer · 2026-06-22T21:58:04Z

🤖 Lint issues have been automatically fixed and committed to this PR.

joshblack · 2026-06-23T20:56:52Z

@copilot fix CI

Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>

Copilot · 2026-06-23T21:27:48Z

@copilot fix CI

Fixed in a39dae7. I addressed the CI failures by fixing lint/type-check issues, making Storybook build @primer/octicons-react-symbols before @primer/react Storybook, and adding a changeset.

joshblack · 2026-06-24T15:51:21Z

@copilot fix CI

Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>

Copilot · 2026-06-24T16:01:50Z

@copilot fix CI

Addressed in 4f4ed4f. I fixed the CI failure by updating OcticonSymbols props typing to correctly accept children, which resolves the TS2322 build/type-check error in @primer/octicons-react-symbols.

…-react-symbols-exploration

primer · 2026-07-10T15:33:24Z

🤖 Lint issues have been automatically fixed and committed to this PR.

primer · 2026-07-10T16:20:44Z

🤖 Lint issues have been automatically fixed and committed to this PR.

joshblack · 2026-07-10T16:35:19Z

@copilot fix CI failures

Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>

Copilot · 2026-07-10T16:58:14Z

@copilot fix CI failures

Fixed in 5b21d22. I resolved the CI failures by restoring JS output for @primer/octicons-react-symbols builds, making lint:npm build before publint, and updating the package’s local React devDependency ranges to avoid the React 19 test mismatch.

joshblack · 2026-07-10T19:14:57Z

+  "scripts": {
+    "build": "node script/build.ts && rolldown -c",
+    "clean": "rimraf dist",
+    "lint:npm": "npm run build && publint --types",


@copilot instead of explicitly building, can we add build as a dependency to this task in turbo?

Done in 9c5c2ab. I removed the explicit npm run build from lint:npm so the task now relies on Turbo’s lint:npm -> build dependency ordering.

Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>

joshblack added 6 commits December 30, 2025 11:20

feat: add octicons-react-symbols package

15f2de9

refactor: update structure for generation and add story

d5ec220

chore: check-in work

9102234

Merge branch 'main' of github.com:primer/react into feat/add-octicons…

dc81c0a

…-react-symbols-exploration

chore: update lockfile

df59274

chore: clean up package

ba2056f

github-actions Bot added the staff Author is a staff member label Jun 22, 2026

github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jun 22, 2026

test: update vitest config

cd7da19

github-actions Bot requested a deployment to storybook-preview-8029 June 22, 2026 20:40 Abandoned

joshblack had a problem deploying to github-pages June 22, 2026 20:45 — with GitHub Actions Failure

github-actions Bot requested a deployment to storybook-preview-8029 June 22, 2026 20:45 Abandoned

chore: add docs and update setup

d777178

joshblack had a problem deploying to github-pages June 22, 2026 22:03 — with GitHub Actions Failure

github-actions Bot requested a deployment to storybook-preview-8029 June 22, 2026 22:03 Abandoned

Copilot started work on behalf of joshblack June 23, 2026 20:57 View session

fix: resolve PR CI failures for octicons symbols package

a39dae7

Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>

Copilot finished work on behalf of joshblack June 23, 2026 21:28

Copilot AI had a problem deploying to github-pages June 24, 2026 14:20 Failure

github-actions Bot requested a deployment to storybook-preview-8029 June 24, 2026 14:20 Abandoned

Copilot started work on behalf of joshblack June 24, 2026 15:51 View session

fix: allow OcticonSymbols children prop typing

4f4ed4f

Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>

Copilot finished work on behalf of joshblack June 24, 2026 16:02

Copilot AI had a problem deploying to github-pages June 24, 2026 21:52 Failure

github-actions Bot requested a deployment to storybook-preview-8029 June 24, 2026 21:52 Abandoned

joshblack added 3 commits July 10, 2026 10:18

Merge branch 'main' of github.com:primer/react into feat/add-octicons…

8cae917

…-react-symbols-exploration

chore: clean up environment

fa6461f

refactor: use dts plugin for build, update docs

6d5d30d

joshblack deployed to github-pages July 10, 2026 15:37 — with GitHub Actions View deployment

github-actions Bot temporarily deployed to storybook-preview-8029 July 10, 2026 15:38 Inactive

joshblack added 2 commits July 10, 2026 10:50

fix: task for lint:npm and add lint-react-compiler

cd28ba0

chore(deps): add react-dom to octicons-react-symbols

a497c2e

joshblack deployed to github-pages July 10, 2026 16:22 — with GitHub Actions View deployment

github-actions Bot temporarily deployed to storybook-preview-8029 July 10, 2026 16:22 Inactive

Copilot started work on behalf of joshblack July 10, 2026 16:37 View session

fix: resolve octicons-react-symbols CI failures

5b21d22

Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>

Copilot finished work on behalf of joshblack July 10, 2026 16:58

joshblack commented Jul 10, 2026

View reviewed changes

Copilot started work on behalf of joshblack July 10, 2026 19:17 View session

Copilot AI deployed to github-pages July 10, 2026 19:23 View deployment

github-actions Bot deployed to storybook-preview-8029 July 10, 2026 19:24 View deployment

chore: run octicons lint:npm build via turbo dependency

9c5c2ab

Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>

Copilot finished work on behalf of joshblack July 10, 2026 19:28

Uh oh!

Conversation

joshblack commented Jun 22, 2026

Changelog

New

Changed

Removed

Rollout strategy

Testing & Reviewing

Merge checklist

Uh oh!

changeset-bot Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Jun 22, 2026

⚠️ Action required

Uh oh!

primer Bot commented Jun 22, 2026

Uh oh!

primer Bot commented Jun 22, 2026

Uh oh!

primer Bot commented Jun 22, 2026

Uh oh!

joshblack commented Jun 23, 2026

Uh oh!

Copilot AI commented Jun 23, 2026

Uh oh!

joshblack commented Jun 24, 2026

Uh oh!

Copilot AI commented Jun 24, 2026

Uh oh!

primer Bot commented Jul 10, 2026

Uh oh!

primer Bot commented Jul 10, 2026

Uh oh!

joshblack commented Jul 10, 2026

Uh oh!

Copilot AI commented Jul 10, 2026

Uh oh!

joshblack Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Jun 22, 2026 •

edited

Loading