Handle bad response on multipart bundle upload#816
Merged
Conversation
The multipart form path in upload_bundle (used when metadata is provided) never called handle_bad_response, so a bad HTTP response propagated as a raw HTTPResponse and caused cryptic downstream failures. Call it for both upload paths. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
karawoo
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #814.
Problem
In
RSConnectClient.upload_bundle(rsconnect/api.py), the multipart form branch (used whenmetadatais provided) never calledhandle_bad_response. Only the plain-tarball branch did. As a result, a bad HTTP response on a metadata upload propagated as a rawHTTPResponseobject rather than raising anRSConnectException, leading to cryptic failures downstream.Fix
Moved the single
handle_bad_responsecall out of theelsebranch so it runs for both upload paths before returning.Test
Added
test_upload_bundle_with_metadata_handles_bad_response, which patchespostto return a failedHTTPResponseon the metadata path and asserts a cleanRSConnectExceptionis raised.🤖 Generated with Claude Code