v8.5.7: bump Go requirement to 1.25 in docs (#23135)#23136
Conversation
ti-chi-bot
added
lgtm
requires-version-specific-changes
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the required Golang version from 1.23 to 1.25 and the Rust version to nightly-2026-01-30 across several documentation files, including hardware requirements, pd-control, pd-recover, and tidb-control. The review feedback suggests rewriting passive-voice sentences in pd-control.md and pd-recover.md to use the active voice and address the user in the second person ("you"), aligning with the repository's style guide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
lilin90
changed the title
lilin90
added
the
do-not-merge/hold
lilin90
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
Bot
merged commit fbc622d
into
pingcap:feature/preview-v8.5.7
2 participants
This is an automated cherry-pick of #23135
What is changed, added or deleted? (Required)
Update documentation to reflect the new Go toolchain requirement.
Changed Go version from 1.23 to 1.25 in hardware-and-software-requirements.md, pd-control.md, pd-recover.md, and tidb-control.md so build/compile instructions and dependency lists are consistent with the current supported Go version.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?