ext/intl: Reset IntlChar error state on method entry#22500
Closed
kn1g78 wants to merge 2 commits into
Closed
Conversation
LamentXU123
requested changes
Jun 28, 2026
LamentXU123
left a comment
Member
There was a problem hiding this comment.
Mostly looks correct. This should target php-8.4 as a bug fix similar to #22119
You should also write NEWS file.
edf320b to
650a371
Compare
LamentXU123
approved these changes
Jun 29, 2026
650a371 to
4866f16
Compare
4866f16 to
7d6f8ce
Compare
LamentXU123
added a commit
that referenced
this pull request
Jun 29, 2026
* PHP-8.5: ext/intl: Reset IntlChar error state on method entry (#22500)
pull Bot
pushed a commit
to KornaPhp/php-src
that referenced
this pull request
Jun 29, 2026
* PHP-8.4: ext/intl: Reset IntlChar error state on method entry (php#22500)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IntlCharmethods did not reset the global intl error state on entry.Because of that, a successful call could still leave
intl_get_error_code()andintl_get_error_message()reporting an error from a previous failedIntlCharcall.
This adds the reset at method entry and a PHPT covering a failed
IntlChar::digit()call followed by a successfulIntlChar::forDigit()call.