Fix GH-14695: Strictly validate invalid upload_max_filesize and post_max_size values#22489
Draft
LamentXU123 wants to merge 3 commits into
Draft
Fix GH-14695: Strictly validate invalid upload_max_filesize and post_max_size values#22489LamentXU123 wants to merge 3 commits into
LamentXU123 wants to merge 3 commits into
Conversation
… and post_max_size values" This reverts commit a720468.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds strict quantity validation for upload_max_filesize and post_max_size.
For ini settings, Invalid values now emit a warning and keep the existing effective value instead of being coerced by backwards-compatible parsing. So
upload_max_filesize=1zzis now parsed as default value2Minstead of1with the warning emitted.And for the
request_parse_body()originally we emit warning and parse those malformed input but now we are throwing ValueErrors to stuff likeupload_max_filesize : ""