Tests: Allow OpenSSL and mysqli tests to run in parallel#22472
Open
LamentXU123 wants to merge 1 commit into
Open
Tests: Allow OpenSSL and mysqli tests to run in parallel#22472LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
Member
|
Wouldn't it be better to make the openssl and mysqli test parallel, rather than faffing with tests that might need to be slow by necessity? (it might even be possible to just remove the conflict file for ext/openssl now that ephemeral ports are used) |
Member
Author
|
The second one is actually slow because the tested behavior is to break the program when memory isn't enough. We could just lower the memory amount to break it way earlier though. The first one is similar (it's testing max execution time. We don't need to wait for the default max execution time) However, I do agree we can just remove the conflict file for ext/openssl now. Let's do it. |
Remove the OpenSSL test directory conflict now that server tests use ephemeral ports. Convert the remaining fixed OpenSSL test ports to ephemeral ports and avoid shared temporary output names between OpenSSL PHPTs. Narrow slow mysqli test conflicts from all to mysql so they remain serialized with other mysqli tests without blocking unrelated extensions.
c354be8 to
f5fe764
Compare
Member
Author
It is faster for a couple of seconds for every OpenSSL and mysql tests as observed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
de-facto we could just lower the ini setting to make it loop less.