Add class to generate redirects.json from redirects.xml sidecar#260
Open
jordikroon wants to merge 1 commit into
Open
Add class to generate redirects.json from redirects.xml sidecar#260jordikroon wants to merge 1 commit into
jordikroon wants to merge 1 commit into
Conversation
This was referenced Jul 6, 2026
derickr
reviewed
Jul 7, 2026
derickr
left a comment
Member
There was a problem hiding this comment.
I don't really have to say much, but feel free to merge this. We can then see if it "breaks" anything, before merging doc-en (and web-php).
Member
|
The Also, So, if the purpose of xml:id collection is to verify if a redirect target exists, this can only be determined by inspecting the rendered chunked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal for this PR is to migrate all doc related redirects out of web-php.
Instead we generate a
redirects.jsonfromredirects.xmlwhich is then loaded in-place.Redirects not related to docs are NOT migrated. However shortcuts are.