⚠ remove HelmChartSupport feature gate and native Helm chart code#2798
Open
pedjak wants to merge 1 commit into
Open
⚠ remove HelmChartSupport feature gate and native Helm chart code#2798pedjak wants to merge 1 commit into
pedjak wants to merge 1 commit into
Conversation
The HelmChartSupport feature gate (alpha, default off) and all code for detecting, pulling, caching, and loading native Helm chart bundles from OCI registries is removed. The path forward on the next bundle format is unclear and may not be Helm, so maintaining this code is not justified. The Helm backend that converts registry+v1 bundles into Helm chart objects for installation (RegistryV1HelmChartProvider) is unaffected. Co-Authored-By: Claude <noreply@anthropic.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the (alpha, default-off) HelmChartSupport feature gate and the associated “native Helm chart bundle from OCI” detection/pull/cache/load implementation, reducing ongoing maintenance burden while keeping the existing Helm backend for registry+v1 bundles intact.
Changes:
- Removed the
HelmChartSupportfeature gate definition and all remaining enablement/default wiring (manifests, Helm values, e2e defaults). - Removed native Helm chart OCI handling in the shared image utilities (chart detection/pull and chart layer unpacking paths) and corresponding unit tests.
- Removed the draft documentation that described how to enable and demo Helm chart support.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/steps/hooks.go | Removes HelmChartSupport from the e2e feature gate defaults map. |
| manifests/standard.yaml | Drops the --feature-gates=HelmChartSupport=false manager arg. |
| manifests/standard-e2e.yaml | Drops the --feature-gates=HelmChartSupport=false manager arg for e2e manifests. |
| manifests/experimental.yaml | Drops the --feature-gates=HelmChartSupport=true manager arg. |
| manifests/experimental-e2e.yaml | Drops the --feature-gates=HelmChartSupport=true manager arg for e2e manifests. |
| internal/shared/util/image/pull.go | Removes the Helm-chart-specific pull path guarded by the feature gate. |
| internal/shared/util/image/helm.go | Deleted: native Helm chart image/bundle helpers. |
| internal/shared/util/image/helm_test.go | Deleted: unit tests for the removed native chart helpers. |
| internal/shared/util/image/cache.go | Removes Helm-chart layer unpacking specialization and related dependencies. |
| internal/shared/util/image/cache_test.go | Removes unit tests that exercised Helm-chart-specific cache behavior. |
| internal/operator-controller/features/features.go | Removes the HelmChartSupport feature gate constant/spec. |
| internal/operator-controller/applier/helm.go | Removes feature-gated “bundle-is-a-chart” detection/loading path; relies on provider only. |
| internal/catalogd/graphql/graphql.go | Removes an outdated comment example referencing helm.chart. |
| helm/tilt.yaml | Removes HelmChartSupport from the enabled feature list. |
| helm/olmv1/values.yaml | Removes HelmChartSupport from default enabled options. |
| helm/experimental.yaml | Removes HelmChartSupport from default enabled options. |
| docs/draft/howto/enable-helm-chart-support.md | Deleted: draft how-to for enabling Helm chart support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
HelmChartSupportfeature gate (alpha, default off) and all codefor detecting, pulling, caching, and loading native Helm chart bundles from OCI
registries.
As noted in #2797 (comment),
the path forward on the next bundle format is unclear and may not be Helm,
making this code a maintenance burden that should be revisited with a broader
design when the time comes.
What's removed:
HelmChartSupportfeature gate constant and spechasChart,pullChart,IsBundleSourceChart,LoadChartFSWithOptions, chart layer unpacking)What's preserved:
for installation (
RegistryV1HelmChartProvider) is unaffectedReviewer Checklist