fix(docs): respect dark theme in badge style dropdown#2913
fix(docs): respect dark theme in badge style dropdown#2913BittuBarnwal7479 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughIn ChangesBadge Style Dropdown Dark Mode
Possibly Related Issues
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@gameroman pls review and merge this PR. |
ghostdevv
left a comment
There was a problem hiding this comment.
I'd like to use appearance: dark (or light) which should be set depending on what theme is being used. The Docus docs have this, but I couldn't find where it was comign from. It doesn't look like it's something they set, but probably should - so we can fix this upstream I think
yes, i had already pushed the fix for this issue in PR #2911 . Since that PR has now been merged, this is already resolved and we can close this PR. thanks for pointing it out! |
ah ok! be careful of accidentally doing that in the future 😅 |
🔗 Linked issue
#2885
🧭 Context
📚 Description
The Badge Style dropdown on the Badges page does not fully respect the active dark theme. When opened in dark mode, the dropdown menu appears with light styling, causing inconsistent appearance and reduced readability. The dropdown should match the active theme for a consistent user experience.