typings: add typing for crypto#64122
Closed
panva wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
panva
added
the
author ready
anonrig
approved these changes
Jun 25, 2026
panva
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64122 ✔ Done loading data for nodejs/node/pull/64122 ----------------------------------- PR info ------------------------------------ Title typings: add typing for crypto (#64122) Author Filip Skokan <panva.ip@gmail.com> (@panva) Branch panva:internal-bindings-crypto -> nodejs:main Labels crypto, author ready, typings Commits 1 - typings: add typing for crypto Committers 1 - Filip Skokan <panva.ip@gmail.com> PR-URL: https://github.com/nodejs/node/pull/64122 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64122 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 25 Jun 2026 08:43:26 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/64122#pullrequestreview-4569361757 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/64122#pullrequestreview-4570463738 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/28284862558 |
panva
added a commit
that referenced
this pull request
Jun 27, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64122 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Member
Author
|
Landed in 47d2d62 |
panva
removed
the
commit-queue-failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add typings for the
internalBinding('crypto')surface used by the JS crypto, TLS, and WebCrypto implementation, and wire the binding intoInternalBindingMap.The declaration models the JS-consumed native surface, including mode-dependent
CryptoJobbehavior, WebCrypto promise jobs,CryptoKey/KeyObjectslot tuples, key generation result shapes, sign/verify/MAC result types, cipher jobs, FIPS/root-certificate helpers,secureHeapUsed(), andtimingSafeEqual().This also adds JSDoc types for the internal WebCrypto job-promise helpers so Promise payloads such as generated
CryptoKeyvalues are preserved throughjobPromise()andjobPromiseThen().