build(deps): move cspell and typedoc to devDependencies#236
Closed
masaru87 wants to merge 1 commit into
Closed
Conversation
Contributor
|
same as #237 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cspellandtypedocare listed underdependencies, but they are only used by thespellcheckandbuild:docsscripts. Nothing undersrc/imports either of them, and the published package only shipsdist/.Because they are runtime dependencies, every application that installs
@moneytree/mt-link-javascript-sdkinstalls them too. Measured with npm against the published 5.1.0:npm auditAll nine advisories come from the cspell/typedoc trees (brace-expansion, minimatch, glob, rimraf, flat-cache, file-entry-cache), so they show up in consumers' audits even though neither tool ever runs in their app.
Verified locally with this change applied:
yarn install—yarn.lockis unchanged (Yarn 4 records workspace dependencies in a single list, so moving between sections does not affect it)yarn test— 15 suites / 110 tests passyarn lint— same 4 pre-existing warnings, no new onesyarn build— succeeds; the regenerateddist/is byte-identicalyarn build:docsandyarn spellcheck— still work, since both tools remain installed for developmentThis will conflict trivially with #225 (typedoc bump) depending on which lands first — happy to rebase.