fix(client): surface streamable HTTP 401 as JSON-RPC error#3051
Open
Sehlani042 wants to merge 1 commit into
Open
fix(client): surface streamable HTTP 401 as JSON-RPC error#3051Sehlani042 wants to merge 1 commit into
Sehlani042 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
No issues found across 2 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1295.
Verification
PATH=/tmp/codex-uv-0.9.5/bin:$PATH uv run pytest tests/client/test_streamable_http.py::test_bare_401_request_maps_to_unauthorized_jsonrpc_error -qfailed withServer returned an error responsevsUnauthorizedPATH=/tmp/codex-uv-0.9.5/bin:$PATH uv run pytest tests/client/test_streamable_http.py::test_bare_401_request_maps_to_unauthorized_jsonrpc_error tests/client/test_streamable_http.py -qPATH=/tmp/codex-uv-0.9.5/bin:$PATH uv run ruff check src/mcp/client/streamable_http.py tests/client/test_streamable_http.pyPATH=/tmp/codex-uv-0.9.5/bin:$PATH uv run ruff format --check src/mcp/client/streamable_http.py tests/client/test_streamable_http.pyPATH=/tmp/codex-uv-0.9.5/bin:$PATH uv run pyright src/mcp/client/streamable_http.py tests/client/test_streamable_http.pygit diff --checkNote: the local Homebrew uv is 0.9.4 while this repo requires >=0.9.5, so verification used an isolated
/tmp/codex-uv-0.9.5binary.