Skip to content

fix(auth): match complete WWW-Authenticate parameters#3012

Open
tarunag10 wants to merge 1 commit into
modelcontextprotocol:mainfrom
tarunag10:codex/www-auth-param-boundary
Open

fix(auth): match complete WWW-Authenticate parameters#3012
tarunag10 wants to merge 1 commit into
modelcontextprotocol:mainfrom
tarunag10:codex/www-auth-param-boundary

Conversation

@tarunag10

Copy link
Copy Markdown

Summary

  • match WWW-Authenticate auth-param names only at parameter boundaries
  • prevent suffix matches such as error_scope satisfying scope
  • add regressions for scope and resource_metadata prefixed parameters

Test plan

  • uv run pytest tests/client/test_auth.py::TestWWWAuthenticate -q
  • uv run ruff check src/mcp/client/auth/utils.py tests/client/test_auth.py
  • uv run pyright src/mcp/client/auth/utils.py tests/client/test_auth.py
  • git diff --check

Related: #2902

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant