Fix RawArray init kwargs retaining stale data#14075
Open
floze-the-genius wants to merge 2 commits into
Open
Conversation
floze-the-genius
marked this pull request as ready for review
July 19, 2026 02:34
floze-the-genius
requested review from
agramfort,
drammock and
larsoner
as code owners
July 19, 2026 02:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Fixes #14074.
What does this implement/fix?
Store the
RawArrayconstructor metadata without a strong reference to the originaldatandarray. Accessing_init_kwargsstill returns a normal constructor-ready dictionary whosedatavalue is the current_dataarray.The regression test uses
weakrefandgcto verify collection after resampling, and covers reconstruction, copying, repr, and pickle round trips.Additional information
Tests:
pytest mne/io/array/tests/test_array.py --no-cov --tb=short -q(4 passed)AI assistance disclosure: OpenAI Codex helped inspect the codebase, implement the property-backed constructor metadata, write the regression test, and run validation. The changes were reviewed against the issue requirements and repository contribution policy.