-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Optional Telemetry Event for Microsoft Store Catalog Installs (msstore Source) #6352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
florelis
merged 11 commits into
microsoft:master
from
shmuelie:user/senglard/Feature6317
Jul 17, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
28a63dc
Force v143 tooling
shmuelie 60c4618
Add store telemetry provider
shmuelie 08d8b20
A method to send StoreExperienceTelemetryWinGetInstall telemetry event
shmuelie f9d1bbd
Fix tracelog provider
shmuelie d9ae4fe
Fix telemetry setup and sending
shmuelie 2fba84d
Send telemetry when from the store
shmuelie f67dcb8
Fix keyword
shmuelie cc5178d
Add more comments
shmuelie 4aaf552
Should use the Microsoft-Windows-Store provider, not the Microsoft.St…
shmuelie e00a5cc
Guard PackageVersion access on install success path
shmuelie 282167a
Address PR #6352 review feedback
shmuelie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -837,13 +837,29 @@ namespace AppInstaller::Logging | |
| m_summary.PackageVersion = version; | ||
| m_summary.RepairExecutionType = type; | ||
| m_summary.RepairErrorCode = errorCode; | ||
|
|
||
| } | ||
| } | ||
|
|
||
| AICLI_LOG(CLI, Error, << type << " repair failed: " << errorCode); | ||
| } | ||
|
|
||
| void TelemetryTraceLogger::LogStoreInstall(std::string_view packageId) const noexcept | ||
| { | ||
| // Don't use IsTelemetryEnabled as that also checks the WinGet provider. | ||
| if (g_IsStoreTelemetryProviderEnabled && m_isInitialized && m_isSettingEnabled && m_isRuntimeEnabled) | ||
| { | ||
| TraceLoggingWrite(g_hWindowsStoreProvider, | ||
| "StoreExperienceTelemetry-WinGetInstall", | ||
| TelemetryPrivacyDataTag(PDT_ProductAndServicePerformance), | ||
| TraceLoggingKeyword(MICROSOFT_KEYWORD_CRITICAL_DATA), | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does it need to be critical? |
||
| AICLI_TraceLoggingStringView(packageId, "pid"), | ||
| TraceLoggingString(m_caller.c_str(), "src"), | ||
| TraceLoggingWideString(L"msstore", "cn") | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| TelemetryTraceLogger::~TelemetryTraceLogger() | ||
| { | ||
| if (IsTelemetryEnabled()) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.