Skip to content

/await:strict and fixes for it#6240

Open
JohnMcPMS wants to merge 4 commits into
microsoft:masterfrom
JohnMcPMS:await-strict
Open

/await:strict and fixes for it#6240
JohnMcPMS wants to merge 4 commits into
microsoft:masterfrom
JohnMcPMS:await-strict

Conversation

@JohnMcPMS

@JohnMcPMS JohnMcPMS commented May 20, 2026

Copy link
Copy Markdown
Member

📖 Description

/await is deprecated; this change removes the CppWinRT injected /await and replaces it with /await:strict. When CppWinRT 3.0 is released, we can remove the build props and it should handle things.

/await:strict caused a few breaks that are also fixed in this PR, namely:

  • a use of return instead of co_return
  • use of std::future in coroutines that is no longer supported inherently; converted to IAsync* types so CppWinRT coroutine support handles them

🔍 Validation

Builds locally, regression tests to ensure functionality.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS added the Next-Release This PR is waiting for the current release to branch before merging. label May 20, 2026
florelis
florelis previously approved these changes May 21, 2026
@Trenly

Trenly commented May 29, 2026

Copy link
Copy Markdown
Contributor

CPPwinRT 3.0 is now released, so the Props updates can be removed and the upgrade can happen

@StephanTLavavej

Copy link
Copy Markdown
Member

Now that the MSVC Build Tools 14.51 have shipped with my "hard deprecation" of the <experimental/coroutine> headers (microsoft/STL#5804), users are reporting that winget-cli is failing to build. Can this PR be polished up and completed?

@Trenly

Trenly commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Now that the MSVC Build Tools 14.51 have shipped with my "hard deprecation" of the <experimental/coroutine> headers (microsoft/STL#5804), users are reporting that winget-cli is failing to build. Can this PR be polished up and completed?

I observed this as well. Specifically, VS2026 18.5.3 works to build the solution while 18.7.2 fails

florelis added 2 commits July 10, 2026 17:04
# Conflicts:
#	src/AppInstallerCommonCore/HttpStream/HttpClientWrapper.cpp
#	src/AppInstallerCommonCore/HttpStream/HttpClientWrapper.h
#	src/AppInstallerCommonCore/HttpStream/HttpLocalCache.cpp
#	src/AppInstallerCommonCore/HttpStream/HttpLocalCache.h
#	src/AppInstallerCommonCore/HttpStream/HttpRandomAccessStream.cpp
#	src/WindowsPackageManager/ConfigurationStaticFunctions.cpp
@florelis florelis marked this pull request as ready for review July 11, 2026 01:14
@florelis florelis requested a review from a team as a code owner July 11, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Next-Release This PR is waiting for the current release to branch before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants