Rewording an error message#14561
Open
bobbrow wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the user-facing messaging shown when #include resolution fails, aiming to address confusion reported in #8227 about “Squiggles are disabled…” wording.
Changes:
- Rewords the
#include errors detected...squiggle-disable messages innativeStrings.json. - Renames three native string localization keys (adds
..._disabled2variants). - Updates the Extension workspace VS Code setting for
files.insertFinalNewline(JSON).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Extension/src/nativeStrings.json | Rewords the include-error squiggle-disable messages (and renames the corresponding localization keys). |
| Extension/.vscode/settings.json | Changes JSON editor setting files.insertFinalNewline to true. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "disable_error_squiggles": "Disable error squiggles", | ||
| "enable_error_squiggles": "Enable all error squiggles", | ||
| "include_errors_update_include_path_squiggles_disables": "#include errors detected. Please update your includePath. Squiggles are disabled for this translation unit ({0}).", | ||
| "include_errors_update_include_path_squiggles_disabled2": "#include errors detected. Please update your includePath. Syntax errors will not be reported until included files are found.", |
| "disable_inactive_regions": "Disable inactive region colorization", | ||
| "error_limit_exceeded": "Error limit exceeded, {0} error(s) not reported.", | ||
| "include_errors_update_compile_commands_or_include_path_squiggles_disabled": "#include errors detected. Consider updating your compile_commands.json or includePath. Squiggles are disabled for this translation unit ({0}).", | ||
| "include_errors_update_compile_commands_or_include_path_squiggles_disabled2": "#include errors detected. Consider updating your compile_commands.json or includePath. Syntax errors will not be reported until included files are found.", |
| "intellisense_client_creation_aborted": "IntelliSense client creation aborted: {0}", | ||
| "include_errors_config_provider_intellisense_disabled": "#include errors detected based on information provided by the configurationProvider setting. IntelliSense features for this translation unit ({0}) will be provided by the Tag Parser.", | ||
| "include_errors_config_provider_squiggles_disabled": "#include errors detected based on information provided by the configurationProvider setting. Squiggles are disabled for this translation unit ({0}).", | ||
| "include_errors_config_provider_squiggles_disabled2": "#include errors detected based on information provided by the configurationProvider setting. Syntax errors will not be reported until included files are found.", |
| "editor.tabSize": 4, | ||
| "editor.detectIndentation": true, | ||
| "files.insertFinalNewline": false | ||
| "files.insertFinalNewline": true |
Contributor
There was a problem hiding this comment.
Uh...seems okay to me.
sean-mcmanus
requested changes
Jul 3, 2026
sean-mcmanus
left a comment
sean-mcmanus
left a comment
Contributor
There was a problem hiding this comment.
Can you remove the "2" from the keys? There doesn't appear to be a reason for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8227
PR for the native side is in progress