Revert "Fix infinite loop"#63617
Closed
liu-idf18 wants to merge 1 commit into
Closed
Conversation
This reverts commit 637d574.
typescript-automation
Bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts prior changes from #63581 (“Fix infinite loop”). In its current form, the revert reintroduces a scanner loop condition that can spin indefinitely, and it also removes a regression test that would help catch this class of issue.
Changes:
- Reverts a precedence fix in
createScanner’s identifier scanning loop involvingCharacterCodes.minus. - Removes a unit test covering
/** ... -*/block comment parsing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/compiler/scanner.ts | Reverts the while condition grouping in identifier scanning, which reintroduces an infinite-loop risk. |
| src/testRunner/unittests/comments.ts | Removes the regression test that exercised block comments ending in -*/. |
| if (isIdentifierStart(ch, languageVersion)) { | ||
| let char = ch; | ||
| while (pos < end && (isIdentifierPart(char = codePointUnchecked(pos), languageVersion) || char === CharacterCodes.minus)) pos += charSize(char); | ||
| while (pos < end && isIdentifierPart(char = codePointUnchecked(pos), languageVersion) || char === CharacterCodes.minus) pos += charSize(char); |
Comment on lines
31
to
32
| }); | ||
|
|
||
| it("parses /** block comments ending in hyphen", () => { | ||
| const sourceFile = ts.createSourceFile( | ||
| "file.ts", | ||
| `${endingInHyphen}\nconst x = 1;`, | ||
| ts.ScriptTarget.ESNext, | ||
| /*setParentNodes*/ true, | ||
| ); | ||
|
|
||
| assert.strictEqual(sourceFile.parseDiagnostics.length, 0); | ||
| assert.strictEqual(sourceFile.statements.length, 1); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #63581