Skip to content

fix(logging): allow child loggers to set independent log levels #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThomasFarstrike wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(logging): allow child loggers to set independent log levels #1077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python-stdlib/logging/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ def basicConfig(
else:
handler = FileHandler(filename, filemode, encoding)

handler.setLevel(level)
handler.setLevel(NOTSET)

@dpgeorge dpgeorge Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default level is NOTSET (see Handler constructor), so I think a simpler and equivalent fix would be to just remove this line.

handler.setFormatter(Formatter(format, datefmt))

logger.setLevel(level)
Expand Down
Loading