test: cover emulator selection reappearing after config directory deleted (PRO-349)#345
Merged
anisaoshafi merged 1 commit intoJul 9, 2026
Conversation
gtsiolis
force-pushed
the
pro-349-emulator-selection-prompt-does-not-reappear-after-configlstk
branch
from
June 26, 2026 22:18
69c6fff to
8c9103e
Compare
gtsiolis
added
semver patch
semver: patch
docs: skip
Claude
gtsiolis
marked this pull request as draft
June 28, 2026 09:04
gtsiolis
marked this pull request as ready for review
June 29, 2026 09:41
gtsiolis
force-pushed
the
pro-349-emulator-selection-prompt-does-not-reappear-after-configlstk
branch
from
June 30, 2026 11:09
8c9103e to
f4ac911
Compare
anisaoshafi
approved these changes
Jun 30, 2026
anisaoshafi
left a comment
anisaoshafi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for increasing test coverage! 🪨
small nit: the fix in title was misleading imo, since it doesn't change any logic, but is about making sure the right behaviour doesn't change.
gtsiolis
force-pushed
the
pro-349-emulator-selection-prompt-does-not-reappear-after-configlstk
branch
3 times, most recently
from
July 3, 2026 07:07
914bee1 to
4f55a78
Compare
Collaborator
|
@gtsiolis are we good to merge this? |
gtsiolis
force-pushed
the
pro-349-emulator-selection-prompt-does-not-reappear-after-configlstk
branch
2 times, most recently
from
July 8, 2026 07:10
f2fc2dc to
9833f03
Compare
Add unit test proving config.Load() returns firstRun=true when the config directory exists but config.toml is absent (e.g. after newLogger recreates the directory). Add integration test covering the full scenario: config directory deleted after successful run triggers the emulator selector on the next run. Co-authored-by: Claude <noreply@anthropic.com>
gtsiolis
force-pushed
the
pro-349-emulator-selection-prompt-does-not-reappear-after-configlstk
branch
from
July 9, 2026 07:08
9833f03 to
328f145
Compare
anisaoshafi
deleted the
pro-349-emulator-selection-prompt-does-not-reappear-after-configlstk
branch
July 9, 2026 07:40
Member
Author
|
Thanks for merging, @anisaoshafi! 🏀 Updated also PR title per #345 (review). |
gtsiolis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes PRO-349
config.Load()correctly returnsfirstRun=truewhen~/.config/lstk/exists butconfig.tomlis absent (the directory-recreated-by-logger scenario does not break first-run detection)Load()returnsfirstRun=truewhen the config directory exists butconfig.tomlis missinglstk startTest plan
make test— unit testTestLoadFirstRunAfterConfigDirRecreatedpassesmake test-integration RUN=TestEmulatorSelectionReappearsAfterConfigDirDeleted— integration test passes (requires Docker)make test-integration RUN=TestEmulatorSelectionReappearsAfterFailedFirstRun— integration test passes (requires Docker)rm -rf ~/.config/lstk/ && lstk start→ emulator selection prompt appears🤖 Generated with Claude Code