Skip to content

ref: update monitor API docstring#702

Merged
yec-akamai merged 3 commits into
linode:devfrom
shkaruna:chore/update-docstring
Jun 8, 2026
Merged

ref: update monitor API docstring#702
yec-akamai merged 3 commits into
linode:devfrom
shkaruna:chore/update-docstring

Conversation

@shkaruna

Copy link
Copy Markdown
Contributor

📝 Description

Update ACLP monitor group doc strings.
Monitor APIs support both v4beta & v4 versions

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?
NA

How do I run the relevant unit/integration tests?
Unit tests:
Run all unit tests:
python -m pytest test/unit -q
452 passed, 7 warnings in 1.11s

Run Monitor alert unit tests:
=================================================== test session starts ===================================================
platform linux -- Python 3.10.12, pytest-9.0.3, pluggy-1.6.0
rootdir: /home/shkaruna/sdk/linode_api4-python
configfile: pyproject.toml
plugins: rerunfailures-16.1, anyio-4.13.0
collected 4 items

test/unit/groups/monitor_api_test.py ....

==================================================== 4 passed in 0.14s ====================================================

Integration tests with v4 & v4beta

v4beta
python -m pytest test/integration/models/monitor/test_monitor.py::test_alert_definition_entities -q -s
.
1 passed in 3.00s

python -m pytest test/integration/models/monitor/test_monitor.py::test_integration_create_get_update_delete_alert_definition -q -s
.
1 passed in 10.66s

v4
export LINODE_API_URL=https://api.linode.com/v4
python -m pytest test/integration/models/monitor/test_monitor.py::test_integration_create_get_update_delete_alert_definition -q -s
Running monitor alert-definition integration test against base_url: https://api.linode.com/v4
.
1 passed in 11.88s

@yec-akamai yec-akamai added community-contribution documentation for updates to the documentation in the changelog. labels May 26, 2026

@satkumar-akamai satkumar-akamai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shkaruna shkaruna marked this pull request as ready for review May 27, 2026 12:31
@shkaruna shkaruna requested review from a team as code owners May 27, 2026 12:31
@shkaruna shkaruna requested review from jbilskiAkam and psnoch-akamai and removed request for a team May 27, 2026 12:31
@yec-akamai yec-akamai requested review from a team and mgwoj and removed request for a team June 5, 2026 14:12
@yec-akamai yec-akamai merged commit cff502a into linode:dev Jun 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation for updates to the documentation in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants