Skip to content

TPT-4056: Fix GitHub Actions script injection vulnerabilities #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zliang-akamai wants to merge 1 commit into
base: dev
Choose a base branch
from
+11 −4
Open

TPT-4056: Fix GitHub Actions script injection vulnerabilities #906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/e2e-suite-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,11 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- run: make MODULE="${{ inputs.module }}" RUN_LONG_TESTS="${{ inputs.run_long_tests }}" test-int
- run: make MODULE="$env:MODULE" RUN_LONG_TESTS="$env:RUN_LONG_TESTS" test-int
env:
LINODE_CLI_TOKEN: ${{ secrets.LINODE_TOKEN_2 }}
MODULE: ${{ inputs.module }}
RUN_LONG_TESTS: ${{ inputs.run_long_tests }}

- uses: actions/github-script@v9
id: update-check-run
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/e2e-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,10 @@ jobs:
pip install .[obj,dev]

- name: Install Package
run: make install SPEC="${{ inputs.OPENAPI_SPEC_URL }}"
run: make install SPEC="$OPENAPI_SPEC_URL"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
OPENAPI_SPEC_URL: ${{ inputs.OPENAPI_SPEC_URL }}

- name: Set LINODE_CLI_TOKEN
run: |
Expand All @@ -129,9 +130,11 @@ jobs:
run: |
timestamp=$(date +'%Y%m%d%H%M')
report_filename="${timestamp}_cli_test_report.xml"
make test-int TEST_ARGS="--junitxml=${report_filename}" TEST_SUITE="${{ inputs.test_suite }}" RUN_LONG_TESTS="${{ inputs.run_long_tests }}"
make test-int TEST_ARGS="--junitxml=${report_filename}" TEST_SUITE="$TEST_SUITE" RUN_LONG_TESTS="$RUN_LONG_TESTS"
env:
LINODE_CLI_TOKEN: ${{ env.LINODE_CLI_TOKEN }}
TEST_SUITE: ${{ inputs.test_suite }}
RUN_LONG_TESTS: ${{ inputs.run_long_tests }}

- name: Upload Test Report as Artifact
if: always()
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,11 @@ jobs:
# DockerFile.
- uses: actions/github-script@v9
id: cli_version
env:
RELEASE_TAG_NAME: ${{ github.event.release.tag_name }}
with:
script: |
let tag_name = '${{ github.event.release.tag_name }}';
let tag_name = process.env.RELEASE_TAG_NAME;

if (tag_name.startsWith("v")) {
tag_name = tag_name.slice(1);
Expand Down