[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding#3444
Closed
optout21 wants to merge 10 commits into
Closed
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding#3444optout21 wants to merge 10 commits into
optout21 wants to merge 10 commits into
Conversation
This was referenced Dec 5, 2024
jkczyz
self-requested a review
December 5, 2024 17:52
optout21
force-pushed
the
splice-dual-tx
branch
from
December 11, 2024 20:33
fb4bd94 to
6a06f1e
Compare
Contributor
Author
|
Rebased to current main, and current state of #3443 . |
optout21
force-pushed
the
splice-dual-tx
branch
from
January 7, 2025 14:11
6a06f1e to
8cc45e4
Compare
Contributor
Author
|
Rebased |
optout21
force-pushed
the
splice-dual-tx
branch
2 times, most recently
from
January 15, 2025 23:22
6e8a1c1 to
dc5a209
Compare
Contributor
Author
|
Rebased; after #3513 many changes disappeared :) |
optout21
force-pushed
the
splice-dual-tx
branch
from
February 11, 2025 07:13
dc5a209 to
27b0ca4
Compare
Contributor
Author
|
Rebased, following channel phase #3418 . The channel manager part got much simpler! |
dunxen
self-requested a review
March 4, 2025 11:37
optout21
force-pushed
the
splice-dual-tx
branch
6 times, most recently
from
March 5, 2025 22:57
fc2e085 to
f93b0de
Compare
Contributor
Author
|
Squashed some commits |
optout21
force-pushed
the
splice-dual-tx
branch
4 times, most recently
from
March 6, 2025 01:14
8b3e9b8 to
8526b4a
Compare
optout21
force-pushed
the
splice-dual-tx
branch
11 times, most recently
from
March 19, 2025 23:27
ad7d810 to
db27917
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3444 +/- ##
==========================================
+ Coverage 89.20% 89.67% +0.46%
==========================================
Files 155 155
Lines 119377 124547 +5170
Branches 119377 124547 +5170
==========================================
+ Hits 106496 111687 +5191
+ Misses 10266 10227 -39
- Partials 2615 2633 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…splice_ack messages, but fail afterwards
…nd OutboundV2Channel
optout21
force-pushed
the
splice-dual-tx
branch
from
March 26, 2025 11:52
db27917 to
3cca201
Compare
Contributor
Author
|
Continued implementation: added |
optout21
force-pushed
the
splice-dual-tx
branch
from
March 28, 2025 07:33
2d7ad1f to
0c66c80
Compare
wpaulino
removed their request for review
April 28, 2025 16:41
Contributor
Author
|
Closing as this prototype is no longer valid/needed 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a next step in the splicing partial implementation, including and depending on the following:
ChannelContextvalue fields intoFundingScope#3592ChannelTransactionParametersintoFundingScope#3604Also relevant: #3418
Next step in splicing (#1621): This PR adds the implementation of performing the interactive transaction negotiation for the new post-splice funding transaction, after the
splice_init&splice_ackhandshake. Only the initiator can currently contribute.The initiator adds the current funding tx as input, plus additional inputs, and the new funding as output plus a change output (if applicable).
After
tx_completethe flow stops, does not yet follow to the commitment/signature exchange.