Skip to content

feat(symbols): add symbols upload command for React Native + Android symbols#745

Merged
abelonogov-ld merged 8 commits into
mainfrom
andrey/symbols-upload-rn
Jul 20, 2026
Merged

feat(symbols): add symbols upload command for React Native + Android symbols#745
abelonogov-ld merged 8 commits into
mainfrom
andrey/symbols-upload-rn

Conversation

@abelonogov-ld

Copy link
Copy Markdown
Contributor

Summary

  • Adds a new ldcli symbols upload command for uploading symbolication artifacts over the dedicated symbol-upload path (large files, multi-segment keys), separate from sourcemaps upload.
  • Supports --type react-native (composed source maps + bundles) and --type android (R8/ProGuard mapping.txt).
  • Keys uploads by a deterministic symbols id (launchdarkly.symbols_id.htlhash) via --symbols-id or an auto-read *.symbolsid sidecar, falling back to --app-version when absent. Storage layout: _sym/{js,android}/id/<symbols-id>/….

Test plan

  • go test ./cmd/symbols/...
  • ldcli symbols upload --type react-native --path ./build --project <key> against a local backend
  • ldcli symbols upload --type android --path ./app/build/symbols/<variant> --project <key>

Made with Cursor

abelonogov-ld and others added 2 commits July 13, 2026 17:41
Align the identifier naming with the `symbols upload` command and the
`_sym/.../id/` storage layout: `--build-id` -> `--symbols-id`, the
`*.buildid` sidecar -> `*.symbolsid`, and the internal prefixes/helpers.

Co-authored-by: Cursor <cursoragent@cursor.com>
Comment thread cmd/sourcemaps/upload.go
Comment thread cmd/symbols/upload.go
Comment thread cmd/symbols/upload.go Outdated
Comment thread cmd/symbols/upload.go
Comment thread cmd/symbols/upload.go
Comment thread cmd/symbols/upload.go

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

There are 4 total unresolved issues (including 3 from previous reviews).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 93cd6cc. Configure here.

Comment thread cmd/symbols/upload.go Outdated
@abelonogov-ld
abelonogov-ld enabled auto-merge (squash) July 20, 2026 22:13
@Vadman97
Vadman97 requested a review from a team July 20, 2026 22:45

@Vadman97 Vadman97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me!

@abelonogov-ld
abelonogov-ld merged commit 8dae666 into main Jul 20, 2026
8 checks passed
@abelonogov-ld
abelonogov-ld deleted the andrey/symbols-upload-rn branch July 20, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants