fix(docs): escape double quotes in Mintlify accordion example titles#1015
Conversation
The generated MDX for a command whose example comment contains double quotes (e.g. 'kosli list controls' with: # list controls whose name or identifier contains "sdlc") produced an invalid JSX attribute: <Accordion title="... contains "sdlc""> which breaks the Mintlify build for that page, so the page fails to render and its BETA sidebar tag is lost. Replace double quotes with single quotes when writing accordion titles.
|
Claude finished @mbevc1's task in 1m 11s —— View job Review: PR #1015 — escape double quotes in Mintlify accordion titles
Verdict: LGTM. Clean, minimal, well-targeted fix with a matching regression test. What the fix does
Strengths
Static analysis
I couldn't execute the test suite here due to tool permissions; build and vet are clean. Please confirm CI is green. Minor (non-blocking)The title could theoretically also be broken by other JSX-significant characters ( |
The generated MDX for a command whose example comment contains double quotes (e.g. 'kosli list controls' with: # list controls whose name or identifier contains "sdlc") produced an invalid JSX attribute:
<Accordion title="... contains "sdlc"">
which breaks the Mintlify build for that page, so the page fails to render and its BETA sidebar tag is lost. Replace double quotes with single quotes when writing accordion titles.