test: Use local FakeServer in tests to avoid real network calls#2165
Merged
Conversation
2257df0 to
3c7e4ca
Compare
3c7e4ca to
e1aa3cf
Compare
Rewrite redirect tests in ApacheHttpTransportTest (v2) and Apache5HttpTransportTest (v5) to use a local FakeServer instead of connecting to google.com, avoiding SSL handshake and network unreachable failures in restricted environments. Also update header tests to use localhost/FakeServer dummy URLs to avoid external network calls. TAG=agy CONV=b7638222-8f45-4b8a-8698-ae587dfa7e88
e1aa3cf to
0eafce0
Compare
blakeli0
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error from #2164
Rewrite testRequestShouldNotFollowRedirects to use a local FakeServer
instead of connecting to google.com, avoiding SSL handshake failures
in environments without proper trust stores (like GraalVM native image tests).
Also update testRequestCanSetHeaders to use localhost dummy URL.
TAG=agy
CONV=b7638222-8f45-4b8a-8698-ae587dfa7e88