fix: derive plan path from feature.json in update-agent-context#3069

Merged

mnriem merged 29 commits into

github:mainfrom

amirreza225:fix/3067-feature-json-plan-path

Jun 26, 2026

Commits on Jun 25, 2026

fix: derive plan path from feature.json in update-agent-context
amirreza225
committed
fix: address Copilot review feedback on update-agent-context
amirreza225
committed
Potential fix for pull request finding

amirreza225
and
Copilot
committed
test: replace time.sleep with os.utime and strengthen PS normalization assertion
amirreza225
committed
Apply suggestions from code review

amirreza225
and
Copilot
committed
Potential fix for pull request finding

amirreza225
and
Copilot
committed
fix: normalize trailing slash and guard non-string feature_directory in PS script
amirreza225
committed
Fix: use .resolve().as_posix().

amirreza225
and
Copilot
committed
fix: use context manager for feature.json open() in bash heredoc
amirreza225
committed
test: add PS coverage for absolute feature_directory outside project root
amirreza225
committed
fix: guard null feature_directory, re-check empty after trailing-slash strip, fix blank line
amirreza225
committed
test: add stale plan to absolute-path tests so feature.json preference is actually exercised
amirreza225
committed
test: convert absolute paths to MSYS2 style for Git-for-Windows bash compatibility
amirreza225
committed
fix: revert PS test to native path, fix bash outside-root assertion for Git bash
amirreza225
committed
fix: use _to_bash_path in not-in assertion for Git bash Windows compat
amirreza225
committed
fix: add ConvertFrom-Json fallback in PS script, write test config as JSON
amirreza225
committed
fix: use OS-appropriate StringComparison in PS prefix-strip (matches common.ps1)
amirreza225
committed
fix: emit project-relative POSIX path from mtime fallback; use upstream test helpers
amirreza225
committed
fix: write config as JSON directly, drop _install_agent_context_config
amirreza225
committed
fix: normalize backslashes to forward slashes in feature_directory before path ops
amirreza225
committed
fix: treat drive-qualified paths (C:/...) as absolute after backslash normalization
amirreza225
committed
fix: resolve symlinks when computing relative plan path; use UTF8 encoding in PS ConvertFrom-Yaml path
amirreza225
committed
fix: use bash-side path for outside-root case to avoid WindowsPath backslashes
amirreza225
committed
fix: use .as_posix() instead of PurePosixPath() to avoid backslashes on native Windows Python
amirreza225
committed
fix: resolve ./.. segments in PS feature_directory via GetFullPath before relativizing
amirreza225
committed
fix: replace $IsWindows guard with OSVersion.Platform check for PS 5.1 StrictMode compat
amirreza225
committed
fix: guard empty relDir to avoid leading slash in PlanPath when feature_directory is project root
amirreza225
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: derive plan path from feature.json in update-agent-context#3069

fix: derive plan path from feature.json in update-agent-context#3069
mnriem merged 29 commits into
github:mainfrom
amirreza225:fix/3067-feature-json-plan-path

Commits on Jun 25, 2026

fix: derive plan path from feature.json in update-agent-context

fix: address Copilot review feedback on update-agent-context

Potential fix for pull request finding

test: replace time.sleep with os.utime and strengthen PS normalization assertion

Apply suggestions from code review

Potential fix for pull request finding

fix: normalize trailing slash and guard non-string feature_directory in PS script

Fix: use .resolve().as_posix().

fix: use context manager for feature.json open() in bash heredoc

test: add PS coverage for absolute feature_directory outside project root

fix: guard null feature_directory, re-check empty after trailing-slash strip, fix blank line

test: add stale plan to absolute-path tests so feature.json preference is actually exercised

test: convert absolute paths to MSYS2 style for Git-for-Windows bash compatibility

fix: revert PS test to native path, fix bash outside-root assertion for Git bash

fix: use _to_bash_path in not-in assertion for Git bash Windows compat

fix: add ConvertFrom-Json fallback in PS script, write test config as JSON

fix: use OS-appropriate StringComparison in PS prefix-strip (matches common.ps1)

fix: emit project-relative POSIX path from mtime fallback; use upstream test helpers

fix: write config as JSON directly, drop _install_agent_context_config

fix: normalize backslashes to forward slashes in feature_directory before path ops

fix: treat drive-qualified paths (C:/...) as absolute after backslash normalization

fix: resolve symlinks when computing relative plan path; use UTF8 encoding in PS ConvertFrom-Yaml path

fix: use bash-side path for outside-root case to avoid WindowsPath backslashes

fix: use .as_posix() instead of PurePosixPath() to avoid backslashes on native Windows Python

fix: resolve ./.. segments in PS feature_directory via GetFullPath before relativizing

fix: replace $IsWindows guard with OSVersion.Platform check for PS 5.1 StrictMode compat

fix: guard empty relDir to avoid leading slash in PlanPath when feature_directory is project root

Commits on Jun 26, 2026

fix: remove unused PurePosixPath import; fix stale PS comment after ConvertFrom-Json fallback was added

fix: use cand.as_posix() for outside-root path instead of raw bash-side argv