fix: allow prerelease spec-kit versions in compatibility checks by DyanGalih · Pull Request #2695 · github/spec-kit

DyanGalih · 2026-05-24T23:03:31Z

Summary

This PR isolates the prerelease compatibility fix from the docs-rendering work.

What changed

Allowed prerelease/dev spec-kit builds to satisfy compatible version specifiers for extensions and presets.
Added regression coverage for prerelease version compatibility.
Kept the fix scoped to the compatibility gate only.

Why

The compatibility checks were rejecting a local prerelease build (0.8.8.dev0) even when the required version range should have accepted it. That blocked otherwise valid extension and preset workflows.

Impact

Dev builds can install compatible extensions and presets again.
Extension update/install flows no longer fail on prerelease version numbers.
The docs-rendering changes from PR generate integrations reference from catalog #2563 stay in a separate branch/PR.

Validation

pytest -q
python3 -m compileall -q .

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR updates spec-kit compatibility checks to treat prerelease/dev builds as satisfying version constraints, and adds regression tests for the new behavior.

Changes:

Allow prerelease versions to satisfy SpecifierSet checks by using specifier.contains(..., prereleases=True).
Add test coverage for prerelease compatibility for extensions and version_satisfies().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
tests/test_extensions.py	Adds tests asserting prerelease/dev versions are treated as compatible.
src/specify_cli/presets.py	Updates preset compatibility check to include prerelease versions.
src/specify_cli/extensions.py	Updates extension compatibility + `version_satisfies()` to include prerelease versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mnriem · 2026-05-27T11:21:20Z

Please address Copilot feedback

…-markdown - Remove standalone scripts/generate_integrations_reference.py - Strip doc injection machinery from catalog_docs.py; keep only table rendering - Wire render_integrations_table() into existing --markdown flag of integration search - Remove old simple markdown table block from integration_search (was Name|ID|Version|Description|Author) - Simplify tests: drop subprocess/doc-path tests, keep table rendering and metadata tests - Clean up docs/reference/integrations.md: remove generated markers, update note

…search - Warn when --markdown is combined with filters (query/--tag/--author) which are silently ignored; catch ValueError/FileNotFoundError and surface clean error via console instead of raw traceback (r3244821516) - Add coverage enforcement in list_integrations_for_docs(): raises ValueError with actionable message if any registry key is missing from INTEGRATION_DOC_URLS, preventing silently incomplete doc tables (r3244821589) - Rename test to accurately reflect sources: label derives from registry config, URL comes from INTEGRATION_DOC_URLS doc map — not solely from registry (r3244821607) - Simplify test dict construction to idiomatic dict comprehension (r3244821619)

…ve sync test (GH Actions job will handle)

…, fix docstring, drop FileNotFoundError

…n header assertion

…pace, optimize missing calculation

…CLI tests

…ception handling

…on test for docs sync

- Rename _get_mocked_cli_runner() to _get_catalog_docs_patches() for clarity - Use ExitStack context manager for guaranteed patch cleanup - Add explicit UTF-8 encoding to file reads - Skip doc sync test gracefully when docs aren't present - Remove exception chaining from typer.Exit to avoid noisy tracebacks

…cell rendering, fix table parser for escaped pipes

…t_markdown_table for escaped pipes, guard community tests with skip

… escape integration URLs

…tions in list

…to prevent double-escaping

… ExitStack, update warning message

…r message, validate test rows, prevent double newline

Allow prerelease/dev builds to satisfy extension and preset compatibility checks when their version number falls within the required specifier range. Also harden the integrations docs rendering helpers and add regression coverage for the markdown table parsing and version gating paths. Tests: pytest -q; python3 -m compileall -q .; black/flake8 unavailable Reference: branch 002-generate-integrations-docs; source patch /tmp/spec-kit-changes.patch

Keep the prerelease/version compatibility fix on its own branch and remove the unrelated integrations docs updates that belong with PR 2563. Tests: full suite passed on the prerelease branch before splitting; docs branch covered by targeted docs tests Reference: upstream/main; source patch /tmp/spec-kit-changes.patch

…ry test

DyanGalih · 2026-06-26T04:45:09Z

I have addressed the review feedback with the latest push:

Centralized Prerelease Policy: Extracted the prerelease compatibility logic into a central version_satisfies helper in src/specify_cli/_utils.py. Updated src/specify_cli/extensions/__init__.py and src/specify_cli/presets/__init__.py to use this new helper.
Failing Boundary Tests: Added failing prerelease boundary cases in tests/test_extensions.py to verify that prerelease strings below the lower bound appropriately fail the check.
Rebase: The branch has also been rebased against the latest upstream/main to resolve conflicts.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

…release tests

DyanGalih · 2026-06-26T04:52:08Z

I've addressed the additional feedback from the automated review:

Reverted the unintended changes to docs/reference/integrations.md so the docs match the active integration registry.
Added test_check_compatibility_prerelease to tests/test_presets.py to explicitly test that preset validation properly processes prerelease versions at boundaries, ensuring coverage for this new path.
The branch has been updated.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

    return rel_path.as_posix()
+
+def version_satisfies(current: str, required: str) -> bool:


            return None


-def version_satisfies(current: str, required: str) -> bool:
-    """Check if current version satisfies required version specifier.
-
-    Args:
-        current: Current version (e.g., "0.1.5")
-        required: Required version specifier (e.g., ">=0.1.0,<2.0.0")
-
-    Returns:
-        True if version satisfies requirement
-    """
-    try:
-        current_ver = pkg_version.Version(current)
-        specifier = SpecifierSet(required)
-        return current_ver in specifier
-    except (pkg_version.InvalidVersion, InvalidSpecifier):
-        return False




mnriem

Please address Copilot feedback

Copilot AI review requested due to automatic review settings May 24, 2026 23:03

Copilot AI reviewed May 24, 2026

View reviewed changes

Comment thread tests/test_extensions.py Outdated

Comment thread src/specify_cli/extensions.py Outdated

DyanGalih added 27 commits June 26, 2026 04:20

docs: generate integrations reference from catalog

487c8db

fix: add sync test, INTEGRATIONS_REFERENCE_PATH constant, and fix naming

6965eda

revert: restore docs/reference/integrations.md to upstream/main; remo…

f150f02

…ve sync test (GH Actions job will handle)

fix: remove dead INTEGRATIONS_REFERENCE_PATH, drop URL-length padding…

67cdfd7

…, fix docstring, drop FileNotFoundError

fix: send --markdown warnings/errors to stderr, rename test for clarity

894b7ae

fix: detect stale doc-map keys, test _render_cell escaping, strengthe…

a48a2ae

…n header assertion

refactor: promote _render_cell to public render_cell function

8e4cd52

test: mock registry and doc maps to avoid brittle live registry coupling

a025d91

refactor: flatten patches, remove unused imports, fix trailing whites…

f905184

…pace, optimize missing calculation

refactor: make validation non-fatal, fix context manager syntax, add …

8a67660

…CLI tests

fix: improve docstring clarity, test robustness, and exception handling

1edc828

fix: improve test assertions, disable warnings by default, enhance ex…

870f07d

…ception handling

fix: make CLI tests deterministic and improve config access resilience

7ef3362

fix: remove extra blank line, add stale keys validation, add regressi…

6efe138

…on test for docs sync

address all outstanding copilot review feedback on PR 2563

234a9f6

Address Copilot feedback: escape URLs in markdown links, deduplicate …

7382206

…cell rendering, fix table parser for escaped pipes

Address 3 new Copilot feedback: add URL escaping test, fix parse_firs…

ee30870

…t_markdown_table for escaped pipes, guard community tests with skip

Address 3 new Copilot feedback: escape id field, remove unused alias,…

34d22b6

… escape integration URLs

Address 3 new Copilot feedback: fix comment name, include all integra…

99b3b99

…tions in list

Fix architectural issue: escape raw fields before composing Markdown …

4a68e82

…to prevent double-escaping

Deduplicate _escape_url_for_markdown_link and add URL escaping test

4e60369

Address 4 new Copilot feedback: add trailing newline, fix test helper…

2a54d7d

… ExitStack, update warning message

Address 4 new Copilot feedback: make escape function public, fix erro…

4589bc4

…r message, validate test rows, prevent double newline

Update error message in test_missing_catalog_file for clarity

70b512f

DyanGalih added 5 commits June 26, 2026 04:29

Remove obsolete integrations sync test

ed78679

keep integrations docs in sync

777df6a

Address PR 2695 feedback: Centralize prerelease policy and add bounda…

032ef4c

…ry test

DyanGalih force-pushed the fix/spec-kit-ci-prerelease-version-gate branch from 057259b to 032ef4c Compare June 26, 2026 04:38

DyanGalih marked this pull request as ready for review June 26, 2026 04:45

DyanGalih requested a review from mnriem as a code owner June 26, 2026 04:45

Copilot AI review requested due to automatic review settings June 26, 2026 04:45

Copilot started reviewing on behalf of DyanGalih June 26, 2026 04:45 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread src/specify_cli/extensions/__init__.py Outdated

Comment thread docs/reference/integrations.md

Comment thread src/specify_cli/presets/__init__.py

Address remaining Copilot PR feedback: revert docs and add preset pre…

1f6fafe

…release tests

Remove unreachable raise CompatibilityError

c2793bd

Copilot AI review requested due to automatic review settings June 26, 2026 04:54

Copilot started reviewing on behalf of DyanGalih June 26, 2026 04:54 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

mnriem requested changes Jun 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: allow prerelease spec-kit versions in compatibility checks#2695

fix: allow prerelease spec-kit versions in compatibility checks#2695
DyanGalih wants to merge 34 commits into
github:mainfrom
DyanGalih:fix/spec-kit-ci-prerelease-version-gate

DyanGalih commented May 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

mnriem commented May 27, 2026

Uh oh!

DyanGalih commented Jun 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DyanGalih commented Jun 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

mnriem left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		return rel_path.as_posix()

		def version_satisfies(current: str, required: str) -> bool:

Uh oh!

Conversation

DyanGalih commented May 24, 2026

Summary

What changed

Why

Impact

Validation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

mnriem commented May 27, 2026

Uh oh!

DyanGalih commented Jun 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DyanGalih commented Jun 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

mnriem left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants