Skip to content

Shared: Generalize typeConstraintBaseTypeMatch #22052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hvitved wants to merge 2 commits into
base: main
Choose a base branch
from
+7,537 −7,505
Draft

Shared: Generalize typeConstraintBaseTypeMatch #22052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8685c44
Rust: Add more type inference tests
hvitved Jun 25, 2026
36724d8
Shared: Generalize `typeConstraintBaseTypeMatch`
hvitved Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions rust/ql/test/library-tests/type-inference/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,10 @@ mod method_non_parametric_trait_impl {
}
}

trait MyTrait2<B> {
fn m3(self) -> B;
}

trait MyProduct<A, B> {
// MyProduct::fst
fn fst(self) -> A;
Expand All @@ -275,6 +279,10 @@ mod method_non_parametric_trait_impl {
x.m1() // $ target=m1
}

fn call_trait_m1_trait2_m3<T1, T2: MyTrait<T1>, T3: MyTrait2<T2>>(x: T3) -> T1 {
x.m3().m1() // $ target=m1 target=m3
}

impl MyTrait<S1> for MyThing<S1> {
// MyThing<S1>::m1
fn m1(self) -> S1 {
Expand All @@ -289,6 +297,13 @@ mod method_non_parametric_trait_impl {
}
}

impl MyTrait2<MyThing<S1>> for MyThing<S2> {
// MyThing<S2>::m3
fn m3(self) -> MyThing<S1> {
MyThing { a: S1 }
}
}

// Implementation where the type parameter `TD` only occurs in the
// implemented trait and not the implementing type.
impl<TD> MyTrait<TD> for MyThing<S3>
Expand Down Expand Up @@ -453,6 +468,8 @@ mod method_non_parametric_trait_impl {
let thing = MyThing { a: S1 };
let i = thing.convert_to(); // $ type=i:S1 target=T::convert_to
let j = convert_to(thing); // $ target=convert_to $ MISSING: type=j:S1 -- the blanket implementation `impl<T: MyTrait<S1>> ConvertTo<S1> for T` is currently not included in the constraint analysis

let x = call_trait_m1_trait2_m3(MyThing { a: S2 }); // $ target=call_trait_m1_trait2_m3 type=x:S1
}
}

Expand Down
Loading
Loading